[fix] disable imputation on future data #562
Merged
+120
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lschilders <[email protected]>
Signed-off-by: lschilders <[email protected]>
Signed-off-by: lschilders <[email protected]>
Signed-off-by: lschilders <[email protected]>
Signed-off-by: lschilders <[email protected]>
…d unit tests Signed-off-by: lschilders <[email protected]>
Signed-off-by: lschilders <[email protected]>
Signed-off-by: lschilders <[email protected]>
Signed-off-by: black <[email protected]>
Signed-off-by: lschilders <[email protected]>
Signed-off-by: lschilders <[email protected]>
Signed-off-by: lschilders <[email protected]>
…taFrame rather than list of index Signed-off-by: lschilders <[email protected]>
Signed-off-by: lschilders <[email protected]>
…ter of test_linear_quantile Signed-off-by: lschilders <[email protected]>
Signed-off-by: lschilders <[email protected]>
egordm
requested changes
Oct 7, 2024
…mine_trailing_null_rows Signed-off-by: lschilders <[email protected]>
Signed-off-by: lschilders <[email protected]>
egordm
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Nice! It looks much cleaner! I think there is one more thing I missed in previous review and we can merge.
For non_null_feature_names to be passable, it should be added here:
https://github.com/OpenSTEF/openstef/blob/main/openstef/model/model_creator.py#L118
Co-authored-by: Egor Dmitriev <[email protected]> Signed-off-by: Lars Schilders <[email protected]>
Signed-off-by: lschilders <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
MissingValuesTransformer, data that had missing "future" values, i.e. features with trailingnullvalues was imputed with theimputation_strategy. This is not desirable since it does not make sense to impute data when it is not in between two known values. Implemented a pre-processing step to remove rows with any trailing null values. Filtered the same rows in the labels accordingly.